-
Notifications
You must be signed in to change notification settings - Fork 32
Support LSM in snapshot-converter and streaming ledger tables #1603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jasagredo
wants to merge
3
commits into
js/lsm1
Choose a base branch
from
js/lsm-sc-da
base: js/lsm1
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12a1acb
to
4119afa
Compare
fraser-iohk
reviewed
Jul 29, 2025
, "- copy the directory " | ||
++ dbPath | ||
++ " to your fast storage device and point to it in your config file." | ||
, "Note this snapshot can only be used by cardano-node >=10.7 configured to use the LSM backend (set the \"LedgerDB\".\"Backend\" key in your config file to \"V2LSM\")." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very minor but this should be "Note that this snapshot"
fraser-iohk
reviewed
Jul 29, 2025
e19927e
to
d9b6101
Compare
3318445
to
ac640be
Compare
1a593c4
to
4c06bb6
Compare
d0867af
to
8aaec9c
Compare
896c314
to
f310574
Compare
75176d7
to
8c25336
Compare
94471a8
to
eb9dac9
Compare
This was referenced Sep 1, 2025
eb9dac9
to
b89e84a
Compare
b89e84a
to
dfb21fe
Compare
dfb21fe
to
0de181c
Compare
0de181c
to
51a81c5
Compare
bec1fb6
to
a81a594
Compare
b1952c4
to
26e8bf2
Compare
Co-authored-by: Alexander Esgen <[email protected]>
33950cc
to
b18f526
Compare
jasagredo
commented
Sep 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is deliberately empty because StreamingLedgerTables it is only used by snapshot-converter
b18f526
to
6273d72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1592
Closes #1602